Skip to content

Fix primary view changing folder for the closing animation

Felix Ernst requested to merge felixernst/dolphin:fix_animation_content_changing into master

BUG: 437080

This commit makes it so the primary view won't change its contents anymore when the split view closing animation is started.

An UrlNavigator that was disconnected from a viewContainer could still temporarily indirectly control the viewContainer because of a dubious connection created in DolphinMainWindow.

Instead the internal UrlNavigator of the viewContainer is used which is always connected to its own viewContainer.

This way the the supposedly disconnected primary UrlNavigator will actually not affect the old disconnected viewContainer that is currently being closed.

FIXED-IN: 21.08

This fix is not targeted at 21.04 because:

  • This kind of internal change is connected to a lot of signals which are connected to more signals which can easily have unintended consequences.

  • The bug being fixed doesn't impede normal use.

Merge request reports