Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Dolphin Dolphin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • SystemSystem
  • DolphinDolphin
  • Merge requests
  • !271

Rewrite filter algorithm to properly support filtering with expanded folders under Detail View mode.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Eduardo Cruz requested to merge ecruz/dolphin:proper_filter_under_expanded_detailview into master Sep 10, 2021
  • Overview 54
  • Commits 10
  • Pipelines 14
  • Changes 2

Rewrite filter algorithm to properly support filtering with expanded folders under Detail View mode.

The previous algorithm kept all the expanded folders visible regardless of the filter. Now we are only displaying an expanded folder that either pass the filter itself, or at least one of its descendants passes the filter.

BUG_411878_before_after

BUG: 411878

This doesn't yet fix this other bug, although it's related.

CCBUG: 442275

Edited Sep 24, 2021 by Eduardo Cruz
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: proper_filter_under_expanded_detailview