Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Dolphin Dolphin
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 7
    • Issues 7
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 28
    • Merge requests 28
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • System
  • DolphinDolphin
  • Merge requests
  • !401

Don't consider drops on a row as drops on the row's item

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Felix Ernst requested to merge felixernst/dolphin:drop_files_on_row into master May 24, 2022
  • Overview 6
  • Commits 2
  • Pipelines 5
  • Changes 2

Since d3839617 in details view mode clicking anywhere within the row is considered a click on the item. That commit also changed it so that dropping files anywhere inside a row would make it so the files are received by the folder of that row.

This commit reverts the drop behaviour to be identical to the old one.

I am having trouble explaining why this is better because one can look at it in different ways. Bottom line is that one doesn't really feel like one is dropping files inside a folder unless the mouse cursor is actually directly above a folder's icon or name.

Another argument is that it is normal behaviour to just throw files onto an application and the files then being opened by it. Having potentially large parts of the view area covered by the rows of folders means that there has to be more of a conscious effort to not drop the files inside one of the folders by accident while with this commit one has to aim precisely onto a folder to do it intentionally.

Related bug report with multiple mentions of this being an issue: https://bugs.kde.org/show_bug.cgi?id=453700

Edited May 24, 2022 by Felix Ernst
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: drop_files_on_row