Skip to content

Clean up code that became redundant through framework changes

Felix Ernst requested to merge felixernst/dolphin:cleanup_redundancy into master

There were two changes in framework that triggered this commit: KHamburgerMenu and KToolTipHelper.

When the Dolphin-specific hamburger menu was replaced by KHamburgerMenu, I didn't clean everything up correctly. Not anymore!

Help texts also weren't updated accordingly. This commit replaces any mention of the old hamburger menu which was called "Control" with text that reflects the current application state.

The other framework change "KToolTipHelper" takes responsibility for opening links in help texts. So we won't need code to do this in Dolphin anymore. This means we can also get rid of some duplicate help texts which only existed because links didn't work correctly in some places.

The only visible changes with this merge request applied should be some adjusted help texts.

I noticed that hyperlinks in whatsThis help messages opened in menus aren't clickable correctly. This is fixed separately in frameworks/kxmlgui!113 (closed).

If it takes a while for this to be merged, we might want to wait until after 22.08 is branched so translators have as much time as possible to react to the string changes in this merge request.

Edited by Felix Ernst

Merge request reports