Skip to content

viewproperties.cpp: use url scheme and host for remote locations

Mike Will requested to merge myqwil/dolphin:viewprops_remote into master

I noticed that when a folder has a remote location, its .directory file will be given the following path:

m_filePath = destinationDir(QStringLiteral("remote")) + m_filePath;

The problem with this approach is that, as far as I can tell, m_filePath still hasn't actually been assigned anything at this point, apart from an empty string. So I propose using this format instead:

view_properties/remote/<url_scheme_if_exists>/<url_host_if_exists>/<url_path>

For example, if we navigate to a shared samba folder on localhost, its .directory file would have this path:

view_properties/remote/smb/localhost/shared_folder/.directory
Edited by Mike Will

Merge request reports

Loading