Skip to content

Start autoActivationTimer only if hovering over a directory

Akseli Lahtinen requested to merge work/akselmo/fix-hover-opening-files into master

Before starting autoActivationTimer, check that we're hovering the item on top of a directory. If we don't check for it, the the autoActivationTimer will try to open the hovered item in it's default application, which can be distracting and break the actual action the user was trying to do, like moving the file to a directory.

I have tested that it does not break the following hover actions

  1. Hovering opens a writable directory
  2. Hovering over desktop file (such as trash://) opens the given directory
  3. Hovering over unwritable folder allows entering into it (current behavior)

I believe this also needs to be fixed because some users may take longer time to decide where they drop the file into, and if they accidentally hover over anything that is not a directory, it will open random windows they did not expect.

BUG:479960

Edited by Akseli Lahtinen

Merge request reports

Loading