Skip to content

Improve DnD handling in read-only dirs

Jin Liu requested to merge work/genericity/dnd-readonly-dirs into master

#55 (closed)

  1. Dropping in a read-only dir now won't create a KIO job, and won't show a menu.
  2. Dragging over read-only dirs in the tabbar or Places panel will show a stop sign, just as in the main view and Folder panel.

Possible problems: DragAndDropHelper::supportsDropping() creates a new KFileItem in each DragMoveEvent. Perhaps it should be cached, but I don't see any slowdown or CPU peak on my machine.

TODO: Breadcrumbs should also do 2, but it's too complex for me.

Merge request reports