Skip to content

versioncontrol: Prevent a use-after-free in UpdateItemStatesThread

Méven Car requested to merge work/meven/crash-477425 into master

UpdateItemStatesThread kept a pointer reference to m_plugin whose lifetime was tied to VersionControlObserver parents. On application shutdown it could happen the thread is still running when the Observer is destroyed.

Make the plugin pointer a weak reference, allowing to stop the thread when the plugin is gone.

BUG: 477425

Edited by Méven Car

Merge request reports

Loading