Skip to content
  • Vyacheslav Korneev's avatar
    Fix double delete bug in OutputWidget · 7b2e5e40
    Vyacheslav Korneev authored and Kevin Funk's avatar Kevin Funk committed
    Summary:
    The bug was unfortunately introduced in D14931 by me - two shared pointers
    were created from the same raw pointer. Eliminated it by using QSharedPointer
    as a return value from view creation helper lambda.
    
    Test Plan:
    The bug can be triggered only in IOutputView:OneView widget mode, which is (as
    far as I can see) currently neither used, nor properly tested. Planning to change
    this in following patches.
    
    Reviewers: kfunk, kossebau
    
    Reviewed By: kfunk
    
    Subscribers: anthonyfieroni, kdevelop-devel
    
    Tags: #kdevelop
    
    Differential Revision: https://phabricator.kde.org/D15241
    7b2e5e40