• Anna Medonosová's avatar
    Continuation of gamut masking effort. · 6194d542
    Anna Medonosová authored
    Summary:
    I have fixed issues from D13525
      * Krita does not crash, if the user tries to save an invalid mask template. Instead, the user is notified and returned to editing, to either fix the error, or cancel the edit.
      * The editing controls are disabled if the user switches to another document.
      * When the artistic color selector loads for the first time, it has correct default values
      * Smaller tweaks and fixes of the code proposed by @dkazakov
    
    There are also new things:
      * There are real gamut masks ready to be used by artists.
      * Gamut masks can be imported and exported in bundles.
      * The UI is simplified, more condensed to save screen space, and hopefully nicer to look at. The mask template and preview icons were updated to better show the mask.
      * The selector can now show numbered gray scale next to the value scale.
    
    Apart from that there are some bugs fixed and better implementations of older features.
    
    I have removed the option to set relative light for the value scale in the selector - it's results seem weird and
    unintuitive - and introduced gamma correction for HSY value scale.
    
    I'm also linking to documents where I prepare user documentation. It is really basic and unrefined for now, but it may be handy while testing.
      - Artistic Color Selector - https://docs.google.com/document/d/1FcLWi9iH9tHfe-4iv9jIi_ZFEkPAc5ilmJ1gCuO-0es/edit?usp=sharing
      - Gamut Masks - https://docs.google.com/document/d/1obXQHYlja7X_lBX0qs8NMH9aiJEostsMcKEP5-1PvKY/edit?usp=sharing
    
    Test Plan:
    Set the artistic selector to your liking (please share your configuration or a screenshot) and create some art using gamut masking (for more information on the subject: [[ https://gurneyjourney.blogspot.com/2008/01/color-wheel-masking-part-1.html|Color Wheel Masking]] and [[ https://gurneyjourney.blogspot.com/2008/02/shapes-of-color-schemes.html | Shapes of Color Schemes ]] by James Gurney). You can either use a default mask or create a new one. Then please share your experience in the following short questionnaire.
    
      # Do you use gamut masking often or uncommonly? Does the implementation support your workflow?
      # Do the default masks provide a good starting point? Is there some fundamental mask missing? If yes, please provide more details on the missing masks.
      # Are the dockers easy or difficult to use?
      # Is the UI clear or did you have trouble finding the right controls? Do the dockers have useful defaults?
      # What do you like and what could be done better?
      # Did you encounter any bugs? If so, please describe them.
    
    Reviewers: #krita, dkazakov
    
    Subscribers: lsegovia, rempt, dkazakov
    
    Tags: #krita
    
    Differential Revision: https://phabricator.kde.org/D14249
    6194d542