Skip to content
  • Frank Reininghaus's avatar
    Make sure that widgets are initialized when changing the view mode · 69c9100f
    Frank Reininghaus authored
    The problem was that DolphinItemListView overrides the virtual function
    onItemLayoutChanged() without calling the base class implementation.
    Therefore, KStandardItemListView::updateLayoutOfVisibleItems(), which
    calls initializeItemListWidget(), is never called.
    
    This patch refactors the "change item layout"/"supports item expanding"
    code a bit to make it more robust and fix the problem that the view
    looks "messed up" when switching from Details View without expandable
    folders to Icons View.
    
    I'm only pushing this patch to master (going to be KDE 4.12).
    The patch is a bit too intrusive for the KDE/4.11 branch for my taste
    at this point of the release cycle, and the bug is not a real
    showstopper. If it works well in master, one could consider backporting
    it to a 4.11.x bug fix release.
    
    Thanks to Emmanuel Pescosta for helping to analyze this issue.
    
    BUG: 302703
    REVIEW: 111632
    FIXED-IN: 4.12.0
    69c9100f