Skip to content
  • Frank Reininghaus's avatar
    Prevent unwanted URL changes when using the Terminal Panel · 9111135f
    Frank Reininghaus authored
    The root cause of the problem was that TerminalPanel's member
    m_konsolePartCurrentDirectory, which is used to determine in
    TerminalPanel::sendCdToTerminal(QString& dir) if the Konsole part's
    directory is aleady 'dir', such that issuing the 'cd' command is not
    needed, was updated too late, namely when the part's
    currentDirectoryChanged(QString) signal was received, which may be up
    to one second after the 'cd' command.
    
    When changing the directory from "dir1" to "dir2" and going back to
    the "dir1" in less than one second (either by using the 'Back' action
    or by activating a tab which still had "dir1" open), the 'cd dir1'
    command was therefore suppressed because the Terminal Panel still
    thought that "dir1" was the current directory in the part. However,
    the directory of the part was actually "dir2", and when the
    currentDirectoryChanged(QString) signal was received from the part, the
    view's URL was set to "dir2" as well.
    
    BUG: 306349
    BUG: 304838
    FIXED-IN: 4.9.2
    9111135f