Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Ark Ark
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • UtilitiesUtilities
  • ArkArk
  • Merge requests
  • !110

Optimize extract file item action

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Kai Uwe Broulik requested to merge work/kbrouli/compress-plugin-optimize into release/22.04 Mar 15, 2022
  • Overview 1
  • Commits 2
  • Pipelines 2
  • Changes 1

Skip non-local files in extract file item action

Ark cannot extract non-local files. Using QUrl::path() to get its local path is incorrect.

This causes Ark to unexpectedly stat a local folder, potentially waking up drives and network mounts, which happens to match the path on the remote location.

For example, opening the context menu in smb://server/some/path will check /some/path locally, potentially causing sleeping drives or network shares to be woken up.

Skip parent directory check if it is already read-only

There's no point in continuing to stat files through QFileInfo if the result will not change.


Kai Uwe Broulik kai_uwe.broulik@mbition.io on behalf of MBition GmbH

https://github.com/mercedes-benz/daimler-foss/blob/master/PROVIDER_INFORMATION.md

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/kbrouli/compress-plugin-optimize