Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Kate Kate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • UtilitiesUtilities
  • KateKate
  • Merge requests
  • !569

Don't use a nested eventloop when renaming files

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Ahmad Samir requested to merge work/ahmad/rename-files into master Jan 19, 2022
  • Overview 20
  • Commits 2
  • Pipelines 8
  • Changes 1

Using a nested eventloop (started by KJob::exec()) meant that in case of file names conflict, the KIO::RenameDialog that is shown can't be accessed at all, as the eventloop of the job blocs all user input events.

Instead make the code async.

Reported by Alexander Volkov: frameworks/kio@fdb8e14e (comment 380644)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ahmad/rename-files