Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Kate Kate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 20
    • Issues 20
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Utilities
  • KateKate
  • Merge requests
  • !83

Merged
Created May 18, 2020 by Jan Paul Batrina@jbatrinaDeveloper

[gdbplugin] Port QRegExp to QRegular Expression

  • Overview 4
  • Commits 3
  • Changes 2

QRegularExpression worked differently, and properly porting to the "new way" would introduce too much changes to the matching. The only way I can come up with was to use variable assignment on the if conditions to (kind of) match the previous paradigm.

I'm not sure if using a static QRegularExpressionMatch (debugview.cpp:282) and assignning to it is the right way to do it, but it is intended to minimize the instantiation of QRegularExpressionMatch.

QRegularExpression::anchoredPattern is used (as per https://doc.qt.io/qt-5/qregularexpression.html#porting-from-qregexp-exactmatch) as I think it better signifies that the whole line has to match, but the same can be done by manually adding the \A and \z to the regex (which solution would be better?).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: gdbplugin-port-to-QRegularExpression