Skip to content

Draft: Make numeric base selection checkboxes and labels vertical

Misc Developer requested to merge miscdeveloper/kcalc:feature/make_numeric_system_base_lines_vertical into master

This change allows the different numeric base labels to display longer values without being elided by stacking them vertically (please see attached image). The content of the labels is copied to the clipboard when clicked, regardless of which checkbox is currently highlighted.

This is my first attempt at contributing to KDE. I am also relatively new to Qt and would greatly appreciate some feedback if the maintainers have time.

  • I am unsure if the layout constraints for the base labels are correct in the UI file. Is there a better way to do this?
  • This code duplicates the text manipulation required to add "0x" to hex values etc. I did this to avoid changes to KCalcDisplay. Is this acceptable?

image

Edited by Misc Developer

Merge request reports