Skip to content

Fatter health indicator

Johan Ouwerkerk requested to merge ouwerkerk/otpclient:fatter-health-indicator into master

I am wondering whether or not it would look better to have taller/fatter health indicators.

I'm not sure what the exact height should be, so I'm putting this out there for review/comment/voting:

Before After
old-height-indicator taller-indicator

This is how the indicators look with a screen full of accounts:

(Note: I restored the old version after on my phone for comparison, so that is why the time is ahead on the "old" version screenshots compared to the new "version" ones.)

Old Android (top) New Android (top)
old-keysmith-lots-of-accounts-android-top keysmith-lots-of-accounts-android-top
Old Android (bottom) New Android (bottom)
old-keysmith-lots-of-accounts-android-bottom keysmith-lots-of-accounts-android-bottom
Old Desktop New Desktop
keysmith-old-lots-of-accounts-desktop keysmith-lots-of-accounts-desktop

This MR builds on top of: !45 (merged)

Edited by Johan Ouwerkerk

Merge request reports