Skip to content
  • David Hallas's avatar
    Fixes minor memory leaks · 03a78c2a
    David Hallas authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
    Summary:
    Fixes a few minor memory leaks found with address sanitizer.
    The newTabButton and closeTabButton was not passed a parent and is not
    deleted in the destructor of TabbedViewContainer which will cause them
    to be leaked when closing a tab. Instead pass the TabbedViewContainer as
    the parent.
    The same goes for the profileMenu, it was not passed a parent pointer at
    contruction and the setMenu function doesn't take ownership of it, so
    therefore it was also leaked.
    
    Test Plan:
    Compile konsole with address sanitizer.
    Open and close konsole.
    
    Reviewers: #konsole, hindenburg
    
    Reviewed By: #konsole, hindenburg
    
    Subscribers: hindenburg, konsole-devel
    
    Tags: #konsole
    
    Differential Revision: https://phabricator.kde.org/D19634
    03a78c2a