Skip to content
  • Mariusz Glebocki's avatar
    Fix "Draw intense colors in bold font" feature · 41693fe9
    Mariusz Glebocki authored and Kurt Hindenburg's avatar Kurt Hindenburg committed
    Summary:
    Make the feature work and improve it slightly - the weight used as bold
    is dependent on selected font's weight. "Regular" will use "Bold", but
    e.g. "Thin" will use "Light".
    
    `styleName` is almost always redundant - all font properties like
    weight, stretch, etc, are stored separately.
    
    Source Code Pro 12pt with font weight set to: Extra Light, Light,
    Regular, Medium, Semibold, Bold:
    {F6631951}
    
    Test Plan:
    In every case: turn on "Draw intense colors in bold font" in Edit
    Profile → Appearance.
    
    **The feature:**
    
    * Use some font which has "Bold" style available and set it to "Regular"
      style.
    * Run: `printf '\033[1mBold|\033[0m|Normal\n'`
    * "Bold|" text should use bold font.
    
    **Different weights:**
    
    * Use some font which has multiple weights available (e.g. Thin, Bold,
      Heavy, ...), e.g. Source Code Pro.
    * Select lightest style.
    * Run: `printf '\033[1mBold|\033[0m|Normal\n'`
    * Select "regular" font style.
    * Bold text for "regular" style should be bolder than the text for
      lightest style should be.
    
    Reviewers: #konsole, #vdg, hindenburg
    
    Reviewed By: #konsole, hindenburg
    
    Subscribers: hindenburg, ngraham, konsole-devel
    
    Tags: #konsole
    
    Differential Revision: https://phabricator.kde.org/D19266
    41693fe9