Skip to content

Reestructure TerminalDisplay code related to HotSpots

Tomaz Canabrava requested to merge tcanabrava/konsole:moveCodeToHotSpot into master

Uffs, this seems to work.

So, this changes a lot how the HotSpot behaves (and I migth have introduced a bug or two, but on my current testing things are doing great, so, ready to review)

tldr: move hotspot based code from TerminalDisplay to the hotspot

Bigger Explanation: The hotspots now behave a bit more like a QGraphicsItem, even tough we are not using a QGraphicsView here, all of them can have a mouseEnterEvent / mouseMoveEvent / mouseLeaveEvent / keyPressEvent (if mouse is over the spot), I'll add more events as needed.

with this we can actually cleanup quite a bit of logic from TerminalDisplay and simplify overall logic in the algorithms, and now we have a proper architecture for the HotSpots.

Edited by Tomaz Canabrava

Merge request reports