Skip to content

Rename "fallback" profile to Built-in

ivan tkachenko requested to merge (removed):rename-builtin-profile into master

  • Complete renaming both in code and UI.

  • Unified style for [Read-only] and [Default] badges in profile manager's list model.

  • Changes --fallback-profile option to --builtin-profile.

  • Backward compatibility: yes. If a user happened to name their profile "Built-in", it would continue to work as normal, and even load with --profile "Built-in" command line flag. It will let them modify any property including Name; but changing the name back to "Built-in" shows a warning and reverts the change as usual.

  • Remove "This option is a shortcut for" sentence. While it is still technically possible to pass built-in profile's magic path, this option is not a shortcut, nor implemented as such.

BUG: 438309 https://bugs.kde.org/show_bug.cgi?id=438309

Is it a new weird flex to refactor 10 C++ files at once, and have them compiled on a first try?

Looks like modified tests are passing. However, I had to invoke them manually, since I'm not familiar with an automated approach.

I seriously recommend double-check everything I did here. Just in case. Triple checked everything is fine.

Edited by ivan tkachenko

Merge request reports