Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Konsole Konsole
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 21
    • Merge requests 21
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • UtilitiesUtilities
  • KonsoleKonsole
  • Merge requests
  • !573

Pass widget again to KNotification on bell

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Luis Javier Merino requested to merge ninjalj/konsole:work/ninjalj/qwidget-in-bell-knotification into master Jan 07, 2022
  • Overview 5
  • Commits 3
  • Pipelines 10
  • Changes 5

67508680 refactored TerminalBell out from TerminalDisplay, and in the process stopped passing the TerminalDisplay widget to KNotification, which resulted in issues when notifications where configured to mark the task bar entry or run a command with %w/%t substitutions (for window id and window title).

Many thanks to Nicole Kleinhoff and Jan Palus who identified the commit that introduced the regression.

CCBUG: 443117 BUG: 443411 BUG: 445520

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ninjalj/qwidget-in-bell-knotification