Skip to content

First round of graphics fixes

Matan Ziv-Av requested to merge matan/konsole:graphics5 into master

This MR includes a few fixes for some of the problems with the graphics protocols implementation that are discussed in !594 (merged) and https://bugs.kde.org/show_bug.cgi?id=449799 and some that I found.

  • Sixel handling should now handle sequences interrupted in the middle and control characters in the middle of a sequence.
  • The images are better placed in the window and scroll with the text (usually).
  • Images are deleted when they cannot be seen any more.

Next I intend to work on bigger changes:

  • Automatic object lifetime handling (unique_ptr).
  • Moving code and data to more appropriate places (active placements to Screen, maybe scrolled placements to history, allowing saving images in the same medium as text).
  • Sixel: support for libsixel high color mode (non indexed images).
  • Documenting kitty protocol (since there are some considerable deviation from kitty's protocol, while sixel and iterm2 protocols are implemented as close as possible to the original).

And of course I'll continue to fix bugs as they are discovered or reported.

Merge request reports