Skip to content

Avoid constructing QChar from non-BMP codepoints

Luis Javier Merino requested to merge ninjalj/konsole:work/ninjalj/get-rid-of-qchar-ctors-from-32bit-char into master

This is fallout from use of UTF-16. While konsole uses an internal 32 bit character type since 5128781a in 2018, there were still scattered places where QChar (which is 16 bit) was constructed from our internal 32 bit character, potentially causing mojibake on Qt5 due to truncation to 16 bits, and assert failures on Qt6.

See https://softwareengineering.stackexchange.com/questions/102205/should-utf-16-be-considered-harmful

Merge request reports