Skip to content

About: Use Qt.createComponent to create About Page

Eamonn Rea requested to merge eamonnrea/krecorder:use-qtcomponent-about into master

This MR uses Qt.createComponent to create the About Page. This works for Widescreen and Mobile configurations. Using this component removes manual logic for maintaining this and instead allows us to use a Kirigami-Addons component available since v1.1.0 that will automatically create the page and pull in the About Page data (unsure if any files need updated to denote this requirement, let me know if I missed something please!)

This should result in no visual changes from master.

Before

Widescreen (shows as separate dialog box in Settings menu)

image

Mobile (shows in single window)

image

After (This MR)

Widescreen

image

Mobile

image


Apologies if this change is undesired, although it does seem like applications are porting to use this. All feedback is welcome if I missed something or did anything wrong. 🙂

Thanks!

Edited by Eamonn Rea

Merge request reports