Skip to content

GitLab

Krusader
Krusader
Closed
Opened by Timur Guzairov@tguzairov

Krusader doesn't delete all selected folders if some of them aren't empty

  1. Request user confirmation for deleting non-empty folder is set to on.
  2. User selects several folders and some of those folders aren't empty
  3. User chooses 'Delete All' at the 'Folder is not empty' warning dialog.
  4. Krusader deletes only folders which were before the first non-empty one. It happens in ListPanelFunc::confirmDeletion We add urls to confirmedFiles set in the loop, then we delete an url from it if user decides not to delete the file, but if they chooses 'Delete All' we just break from the loop without adding the rest of urls to the set.

File: krusader/Panel/panelfunc.cpp Inside if (emptyDirVerify) {

else if (result == KMessageBox::No) {
  break; // accept all remaining

But after the loop we just assign toDelete = confirmedFiles.values();