Skip to content

New tabs start in the current folder and can be inserted next to the current tab or at the end

Toni Asensi Esteve requested to merge work/new_tab into master

People who use Konsole, Double Commander, Total Commander or Dolphin are used to the fact that when they open a new tab, it starts from the same folder that they were using. When trying Krusader, they do not expect that new tabs start from the home folder. After applying the present changes, new tabs start in the current folder, like it happens with the other programs.

More information:

  • If the user is working on a folder, it's more frequent that the next action is going to be done in that folder or near it (a subdirectory, upper directory, etc.) instead of in the home folder. Anyway, going to the home folder is easy with a hotkey (Alt+Home) or using a Krusader button that can be enabled.

Also, with this merge request, new tabs can be inserted next to the current tab or at the end. Users can choose that (in Settings > Configure Krusader > Panel > General > Insert Tabs After Current), like in Konsole, Double Commander or Total Commander.

Related information:

  • As a user wrote: "The default behavior of Firefox opening new tabs at the end of the list is annoying me for a while now. This is distracting me, when I open a new tab correlated to the currently active tab. With many open tabs the resulting distance between the new tab and the previously active tab makes this difficult without moving the new tab and thus makes this everyday scenario very difficult to handle efficiently. [Those problems were solved after] changing 'browser.tabs.insertAfterCurrent' from the default setting of 'false' to 'true'".
  • The new source code utilizes the one of Closing a tab can be undone. It's been used since 4th of June without seeing any problem.

TEST PLAN

STEP 1: Apply the proposed changes.

STEP 2: Using the left panel:

Check that, at the end of the tab bar, a new tab is added when doing those operations:

  • Click on the "Open a new tab button" (it's placed after the bar).
    • Also, check that the new tab starts from the current folder
  • Right-click on a tab with the mouse, select New Tab.
    • Also, check that the new tab starts from the current folder
  • Press Ctrl+T.
    • Also, check that the new tab starts from the current folder
  • Press Ctrl+D, middle-click (using the middle click of the mouse) on a bookmark
  • Go to Tools > Search..., type *, press "Search" and later press "Feed to listbox", press return when asked "Here you can name the file collection".
  • Go to Tools > Locate..., type /usr/bin/x*, press "Locate", press "Feed to listbox", press return when asked "Here you can name the file collection".
  • Go to Tools > Synchronize Folders..., select two folders, press "Compare", "Feed to listbox", press return when asked "Here you can name the file collection".
  • Open a new tab, go to /usr, "lock" the tab, enter a folder.
    repeat the same tests after enabling the "Insert Tabs After Current" option (it can be enabled in Settings > Configure Krusader... > Panel > General) and this time {check that each new tab is added next to the current one}.

Check that a new tab is added next to the current one when doing those operations:

  • Duplicate a tab (using the mouse or the keyboard).
  • Place the cursor on a folder and press Ctrl+Alt+Return.

Note: Nowadays, those two operations open a tab the next to the current one, and that is kept after applying the proposed changes.

Check that no tab is added when doing:

  • Press Ctrl+D, click on a bookmark.
  • Open a new tab, go to /usr, "pin" the tab, enter a folder.

Try previous tests when having only one tab, when having two tabs, when being on the first of two tabs, when being on the second of two tabs, the second of three tabs, the second of four tabs, etc.

STEP 3: Repeat the same tests, though this time using the right panel.

STEP 4: Take a screenshot of Krusader (so it can be used later in order to make a comparison). Close Krusader. Open Krusader and check that previous tabs were saved and check that now are displayed in their correct order.

STEP 5: Perform other tests that you find useful.

Edited by Toni Asensi Esteve

Merge request reports