Skip to content

Complete main functions of the project

Phu Nguyen requested to merge work/refactor into master

This package can now be used for all website projects that are related to the shared Hugo theme, including the shared theme project itself.

  • Define cases based on environment variables set by scripty; documentation will come later
  • Handle STATICMESSAGES_FILE (aether-sass, apps-kde-org, elisa-kde-org, kate-editor-org, okular-kde-org, plasma-mobile-org) and MESSAGES procedures (kde-org, planet-kde-org); still STATICMESSAGES_DIR is left (timeline-kde-org)
  • Add command to fetch PO files from SVN
  • Get rid of --directory parameter; add description and help messages
  • Rename Python package, update package info and package entry point command; still keep repo URL

@carlschwan

After rechecking the MR I can see that it's difficult to follow since all files are marked as deleted or added. It might be a bit easier to check each commit, the main changes happened in 3a81aeac. And here is my attempt to summarize:

  • There are three cases to handle, corresponding to 3 Proc (in procedure.py), and these are determined (get_proc() in procedure.py) by FILENAME and EXPORTS_POT_DIR environment variables set by scripty:
    • STATICMESSAGES_FILE corresponds to when StaticMessages.sh is used with file functions (export_pot_file, import_po_files), and STATICMESSAGES_DIR is for when StaticMessages.sh is used with dir functions;
    • MESSAGES is for when Messages.sh is used
    • PACKAGE env var is also used and needs to be set when scripty is not involved (sysadmin/binary-factory-tooling!167 (merged))
  • No classes anymore, only functions
  • All operations related to extraction are in extraction.py (renamed from extractors.py), all related to generation are in generation.py (renamed from generators.py), no more importers.py, "import" is now called "compile" and the whole of this operation is in command_line.py.
Edited by Phu Nguyen

Merge request reports

Loading