Draft: Proof-of-concept patch for threaded openGL texture uploading
Hi, @ivany!
Could you please test this patch on OSX? The test plan in the follwoing:
-
Build Krita with this patch
-
Before creation of the image, go to
Preferences->Display
and disable "Use texture buffers" checkbox. -
Create an image of 5000x5000
Check the debugging output, I'm interested in the two lines that look like that:
[10296] Entering "KisOpenGLCanvas2::initializeGL()" d->uploaderContext->isValid() = true [10296] Entering "KisOpenGLCanvas2::initializeGL()" QOpenGLContext::supportsThreadedOpenGL() = false
-
Make sure that
View->Instant Preview
is disabled. -
Try to paint something. It shouldn't crash. If it doesn't have any artifacts, it is perfect ;)
-
Try to do extremely quick strokes on the canvas and check for the "bended lines" problem.