Skip to content

Massive cleanup for the Preferences dialog

Amy spark requested to merge lsegovia/krita:work/amyspark/preferences-layout-cleanup into master

This MR cleans up the layout of all widgets involved in the Preferences dialog.

The changes are too many to be individualized here, but they center around:

  • removing padding throughout the individual panes
  • using form layouts whenever possible (which helps accessibility)
  • and flattening unnecessarily nested layouts.

I've made two Imgur portfolios here for a before/after look:

Before: https://imgur.com/a/Klc3eaN

After: https://imgur.com/a/EHi07LZ

Test Plan

Build Krita and test the Preferences panes in your system.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

/cc @woltherav

Edited by Amy spark

Merge request reports