Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 74
    • Merge requests 74
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1328

Massive cleanup for the Preferences dialog

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Amy spark requested to merge lsegovia/krita:work/amyspark/preferences-layout-cleanup into master Feb 10, 2022
  • Overview 8
  • Commits 18
  • Pipelines 5
  • Changes 26

This MR cleans up the layout of all widgets involved in the Preferences dialog.

The changes are too many to be individualized here, but they center around:

  • removing padding throughout the individual panes
  • using form layouts whenever possible (which helps accessibility)
  • and flattening unnecessarily nested layouts.

I've made two Imgur portfolios here for a before/after look:

Before: https://imgur.com/a/Klc3eaN

After: https://imgur.com/a/EHi07LZ

Test Plan

Build Krita and test the Preferences panes in your system.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

/cc @woltherav

Edited Feb 11, 2022 by Amy spark
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/amyspark/preferences-layout-cleanup