Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Bugzilla
    • Bugzilla
  • Merge requests 77
    • Merge requests 77
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !1331

Round 2 of Preferences layout improvements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Amy spark requested to merge lsegovia/krita:work/amyspark/macos-miscellaneous-panel into master Feb 13, 2022
  • Overview 11
  • Commits 10
  • Pipelines 4
  • Changes 4

This MR applies the suggestions of @alvinwong in !1328 (comment 397209) about grouping some of the sets of checkboxes.

I've also changed some repetitions of strings in "Swap File" panel, and added a scrolling area for the Miscellaneous tab of the General pane; I'm running on height limitations on my 13" Macbook Pro.

Relevant portfolios:

  • Before !1328 (merged): https://imgur.com/a/Klc3eaN

  • After !1328 (merged): https://imgur.com/a/EHi07LZ

  • After this MR: https://imgur.com/a/WkOcp76

Test Plan

Build Krita.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

/cc @alvinwong

Edited Feb 13, 2022 by Amy spark
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/amyspark/macos-miscellaneous-panel