Skip to content

Document modified while closing

Grum 999 requested to merge grum/krita:grum999/do_not_modify_closed_document into master

Following discussion from MR #2147

  1. Modified signal on document destruction: looks like a candidate to a separate patch.

While document is closing (KisDocument destructor), ensure:

  • the 'modified' status is not updated
  • document properties are not modified
  • no 'modified' signal is emitted

Test Plan

Ensure everything is fine (no error message, no crash) whe:

  • Create a document, close it
  • Create a document, modify it, close it
  • Create a document, modify it, save it, close it
  • Open a document, close it
  • Open a document, modify it, close it
  • Open a document, modify it, save it, close it

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports