Skip to content

Fix asserts when using touch alongside the stylus on the touch-capable laptops

Thatt should fix this bug that blocks the Steam release: https://bugs.kde.org/show_bug.cgi?id=489537

Test Plan

  1. Touch while stylus stroke

    1. Start a stylus/mouse stroke, don't release the button
    2. Do a tap or two-finger tap or tap+drag to activate a touch action
    3. No assert should happen, the tablet action should continue
    4. Repeat for Left and Middle mouse/tablet buttons
  2. Stylus stroke while touch action

    1. Start a touch stroke (e.g. Pan or Zoom)
    2. Try to perform a stylus action
    3. No assert should happen, the touch action should continue
  3. Repeat steps 1 and 2 for "native gestures" if you are using MacOS or Android (I have no idea what these actions are)

  4. Focus-out while touch action 0) Open another app in parallel to Krita

    1. Start a touch stroke (e.g. Pan or Zoom)
    2. Focus-out while touch is still in progress (e.g. with Alt+Tab)
    3. No assert should happen, the action should either auto-end or continue (depending on the OS and windows layout)
  5. Repeat step 4 for "native gestures" if you are using MacOS or Android

  6. Reactivation of a secondary action after touch-end

    1. Press Ctrl to preactivate color picker (without tablet/mouse press)
    2. Start a touch action (e.g. Pan or Zoom) (while keeping Ctrl pressed)
    3. End the touch action (while keeping Ctrl pressed)
    4. [known issue] move the mouse cursor to make the cursor update
    5. The color picker should still be preactivated
    6. Press stylus/mouse to start color picking
    7. No assert should happen, color picking should start normally

Merge request reports

Loading