Skip to content

Apply i18n to spinbox percent values

Ross Rosales requested to merge rossr/krita:rossr/FormatPercentValues into master

Building off of BUG:462128 list of changes
Context: !2000 (merged), !1963 (merged)

This MR builds off of previous work for i18n(internationalization) of percent values in Krita.
For example in English: 100% is used, and in Turkic: %100 is used to display percent values.

Test Plan

I am unfamiliar if a translation file has been created/referenced for percent values. Please correct and point me in the right direction.
In the case it does/will exist; to test the changes:
change language to respective user -> search the tool in Krita -> find the value in percent
The value should reflect the chosen language.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Ross Rosales

Merge request reports