Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Krita Krita
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Bugzilla
    • Bugzilla
  • Merge requests 71
    • Merge requests 71
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • GraphicsGraphics
  • KritaKrita
  • Merge requests
  • !553

428014 Correctly add barrier jobs for KisGeneratorStrokeStrategy

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Amy spark requested to merge lsegovia/krita:work/amyspark/428014-fix-barrier-jobs into krita/4.3 Oct 26, 2020
  • Overview 2
  • Commits 0
  • Pipelines 0
  • Changes 0

The correct type of job to block Fill Layer updates is BARRIER -- update jobs cannot start unless we are sure the previous set has been cleared and committed to the canvas.

CCBUG:427199

BUG: 428014

Test Plan

  1. Create a big canvas (for my Ryzen box, 4k x 4x suffices).
  2. Add a Fill Layer and select the Screentone generator.
  3. Go to the Transformation tab and spin the Rotation spinbox very madly ;)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/amyspark/428014-fix-barrier-jobs