Skip to content

428014 Correctly add barrier jobs for KisGeneratorStrokeStrategy

Amy spark requested to merge lsegovia/krita:work/amyspark/428014-fix-barrier-jobs into krita/4.3

The correct type of job to block Fill Layer updates is BARRIER -- update jobs cannot start unless we are sure the previous set has been cleared and committed to the canvas.

CCBUG:427199

BUG: 428014

Test Plan

  1. Create a big canvas (for my Ryzen box, 4k x 4x suffices).
  2. Add a Fill Layer and select the Screentone generator.
  3. Go to the Transformation tab and spin the Rotation spinbox very madly ;)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports