Skip to content

Use KStandardGuiItem with QDialogButtonBox in C++ widgets

Alvin Wong requested to merge alvinwong/krita:alvin/qdialogbuttonbox into master

Make most QDialogButtonBox (at least on the C++ side) use translations from KWidgetsAddons, which from what I see with zh_TW seems to be higher in quality than the ones from Qt. The ones in Qt are missing the accelerator keys.

Also makes the save brush preset dialog use QDialogButtonBox.

While I was testing it out, I noticed that the recorder "export timelapse" dialog and the "clean up recordings" dialog does not use QDialogButtonBox and thus have a custom button ordering. It is a bit more complicated to change it to use QDialogButtonBox, but I thought I'd make a note here.

Test Plan

  • Check that the buttons in most dialogs are translated according to the KWidgetsAddons translations (note: needs !905 (merged) unless your system language is not English)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • n/a I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports