Skip to content

Draft: Fix some problems in ToggleActionMenu

Laura David Hurka requested to merge davidhurka/okular:fix-toggleactionmenu into master

I managed to crash ToggleActionMenu while experimenting for !246 (closed), so I added QPointers.

  • Use QPointer more often to not crash when e. g. the default action gets deleted
  • Limit recursions in checkedAction(), because I don’t remember whether QMenu loops are impossible
  • Describe defaultAction() using an ordered list, because I now agreed that it is hard to understand
Edited by Laura David Hurka

Merge request reports