Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Breeze visual style
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Breeze visual style
  • Merge requests
  • !147

kstyle: Add QFocusFrame to non-view/delegate interactive widgets

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Noah Davis requested to merge work/ndavis/focusframe into master Sep 22, 2021
  • Overview 63
  • Commits 1
  • Pipelines 0
  • Changes 2

There are 2 parts that contain the bulk of the code in this patch.

Style::event() is used to apply the QFocusFrame to a widget when it gets focus with a keyboard input related focus reason. If the focused widget has a focusProxy, this makes sure the QFocusFrame is applied to the focusProxy instead.

Style::drawFocusFrame() is mostly what you'd expect. It draws a focus frame based on the type of widget the QFocusFrame was applied to. I had to do a workaround for QFocusFrame not fully repainting outside the bounds of QSliders and QDials when the handle moves though. What I do is check if _focusFrame is defined and then _focusFrame->update().

BUG: 443469

breeze-focusframes-mrvid-2021-09-22_16.28.02

@teams/vdg @teams/usability


Things I need to add support for:

  • group box checkboxes (thanks @nyanpasu)
Edited Oct 08, 2021 by Noah Davis
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/ndavis/focusframe