Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Breeze visual style
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Breeze visual style
  • Merge requests
  • !53

Improve drawing of header separators

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Fabian Vogt requested to merge work/fixheader into master Nov 15, 2020
  • Overview 10
  • Commits 2
  • Changes 1

This avoids a double wide edges between headers and the surrounding frame. As a side effect this fixes drawing of some separators, like between A and B in the RTL screenshot.

Only downside is that the last separator is now drawn 1px further outside, so doesn't perfectly align with the table in the third screenshot. I only notice that because I was actively looking for it though.

The spreadsheet application is from qtbase's examples, with the window size forced to 631x427 (any smaller would need scrollbars) with gammaray.

Currently built on top of !54 (merged)

Before After
Kate Before Kate After
Kate + Scrollbar Before Kate + Scollbar After
Screenshot_20201118_202732 Screenshot_20201118_202821
Spreadsheet Before LTR Spreadsheet After LTR
Spreadsheet Before RTL Spreadsheet After RTL
Edited Nov 18, 2020 by Fabian Vogt
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/fixheader