Skip to content

Initially adopt current brightness of external brightness device

Sits on top of MR !6596 (closed), let's get that one figured out first. Requires libraries/plasma-wayland-protocols!86 (merged) and works in tandem with powerdevil!450 (merged).

Is there any chance this could also get backported to 6.2 to fix BUG: 494408? Or is that impossible if a new protocol version is required?


This prevents KWin from amping up every display's brightness to 100% after a 6.2 update. Subsequent changes through a monitor's OSD menu or another software's DDC/CI commands are still ignored.

Depends on an interface addition to external-brightness-v1 from plasma-wayland-protocols.

BUG: 494408 CCBUG: 494497


Bonus commit: wayland/externalbrightness: Fix order of id and version arguments

QWayland places id before version, and the code in kde_external_brightness_v1_create_brightness_control() will pass these arguemnts to the ExternalBrightnessDeviceV1 constructor in that order.

However, the ExternalBrightnessDeviceV1 constructor signature itself has them swapped, which luckily didn't cause problems because the call to QtWaylandServer::kde_external_brightness_device_v1() also passes the arguments in the wrong order, swapping them back.

This commit makes the constructor use the correct order in the first place.

Edited by Jakob Petsovits

Merge request reports

Loading