Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • M Milou
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Milou
  • Merge requests
  • !41

ResultDelegate: Fix height binding loop on multiline

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ismael Asensio requested to merge work/iasensio/fix-multiline-bindingloop into master May 29, 2022
  • Overview 1
  • Commits 1
  • Pipelines 3
  • Changes 1

This binding loop was making krunner freeze when the text expanded more than 3 lines

We shouldn't be setting the height on an item based on their childrens height. Luckily, the Layout automatically calculates this for us

BUG: 454507 FIXED-IN: 5.24.6

I'm not sure whether to cherry-pick this also to 5.24LTS besides 5.25?

While the bug is difficult to trigger (there are not many multiline runners still), it's quite cumbersome and makes krunner unusable in those situations, so I'd say it qualifies.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/iasensio/fix-multiline-bindingloop