Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 31
    • Issues 31
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 58
    • Merge requests 58
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !1483

Use PlasmoidHeading and more compact design proposal

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Niccolò Venerandi requested to merge work/niccolove/plasma-desktop-more_ui-nicco into master Apr 20, 2023
  • Overview 41
  • Commits 5
  • Pipelines 5
  • Changes 2

This MR builds on top of the work done by @tantalising here: !1395 (closed)

After having done a code review, I think that the code is absolutely okay, it was missing proper header and footer through PlasmoidHeading, so I implemented those (first commit of this MR). That's a minor change that imvho is required to land the MR; with this first commit, it's approved from me already:

image

However, I felt like the dialog could be made a bit more compact, so I gave a shot at a different layout. Here's my proposal, which I think is slightly better, but really I'm fine either way:

image

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/niccolove/plasma-desktop-more_ui-nicco