Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 46
    • Merge requests 46
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !541

[containments/panel] Fix panel applet configuration with touch

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nate Graham requested to merge ngraham/plasma-desktop:fix-panel-applet-configuration-with-touch into master Aug 05, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

Despite this UI seeming very touch-centric, it was actually totally boken for the touch use due to the use of mouse-specific code, namely setting the current applet only when the mouse moved and also hiding the tooltip when the mouse edited the area--neither of which are compatible with authentic touch events when handled by a mouse area, because the synthesized mouse position exits the mousearea as soon as the finger used to touch the screen is retracted.

This is fixed by setting the current applet when clicked/touched as well, and removing the onExited signal handler to hide the tooltip, which was unnecessary anyway because the tooltip gets hidden by other things and this still works.

Now touch interaction with panel applets while in panel edit mode works as expected.

BUG: 439918 FIXED-IN: 5.22.5

cc @niccolove @thiagosueto

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-panel-applet-configuration-with-touch