Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Plasma Desktop Plasma Desktop
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 48
    • Merge requests 48
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma DesktopPlasma Desktop
  • Merge requests
  • !598

[applets/kicker] Explicitly set visible property when opacity is 0

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged David Edmundson requested to merge work/icon_speedup into master Oct 14, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

The Dashboard representation contains 3 views stacked on top of each other with one visible at a time with an opacity animation.

Enabled was used (presumably) to ensure that only the active representation gets input events.

Unfortunately this has a side effect. When switching views the icons on the inactive view all get enabledChanged events. This triggers a redraw with a greyed out effect on all icons. This is a very slow path, especially for something not even visible!

Setting visible also stops input events, without the side effect. Verified with qDebug in IconItem::polish

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/icon_speedup