Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Bugzilla
    • Bugzilla
  • Merge requests 124
    • Merge requests 124
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • PlasmaPlasma
  • Plasma Workspace
  • Merge requests
  • !1123

[kcms/colors] Notify global settings change after saving

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Nicolas Fella requested to merge work/fixcolornotify into master Oct 16, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 4

ManagedConfigModule::save() writes the value for the 'ColorScheme' entry to disk.

If we notify the settings change anyone who connects to it may read the old value before the new one is saved.

To avoid this race consition emit the signal after saving instead of before

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: work/fixcolornotify