Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P Plasma Workspace
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 96
    • Merge requests 96
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Plasma
  • Plasma Workspace
  • Merge requests
  • !1123

Merged
Created Oct 16, 2021 by Nicolas Fella@nicolasfellaDeveloper

[kcms/colors] Notify global settings change after saving

  • Overview 0
  • Commits 1
  • Changes 4

ManagedConfigModule::save() writes the value for the 'ColorScheme' entry to disk.

If we notify the settings change anyone who connects to it may read the old value before the new one is saved.

To avoid this race consition emit the signal after saving instead of before

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: work/fixcolornotify