Skip to content

SystemDialog: fix some bugs

Nate Graham requested to merge ngraham/plasma-workspace:fix-bugs-in-systemdialog into master

Two commits that should not be squashed:

commit b66bd54d546346a04c90869d0dc065e07c74bf95
Author: Nate Graham <nate@kde.org>
Date:   Sun Oct 23 09:34:50 2022 -0600

    SystemDialog: force title and subtitle labels to support Rich Text
    
    The sefault setting of "mightBeRichText" does not behave correctly with
    KUIT markup, so if either of these labels do use any KUIT markup, it is
    not displayed properly. The heuristic used is fast and simple; since we
    know that we want KUIT markup to be supported, let's bypass it and
    manually specify that rich text is supported here.
commit 5e9037d7c458e7fd189cbf615d8e57a1efc2984b
Author: Nate Graham <nate@kde.org>
Date:   Sun Oct 23 08:10:00 2022 -0600

    SystemDialog: stop using two data sources for titleHeading label
    
    Right now the titleHeading label gets its text from two places:
    1. its `text` property is directly bound to root's `title` property
    2. its `text` property is also aliased to root's `mainText` property
    
    This creates a non-deterministic multiple-sources-of-truth problem and
    also causes an odd UX whereby if only the title property is defined,
    the same text is shown in both the window's titlebar, and also right
    below it in the window content itself. This is redundant.
    
    To fix this, let's only get the text from the mainText property and let
    the title property only set the window title.

This supports xdg-desktop-portal-kde!132 (merged).

@apol

Edited by Nate Graham

Merge request reports