Skip to content

ShellCorona: Activate launcher menu even when no global shortcut is set

Tatsuyuki Ishi requested to merge ishitatsuyuki/plasma-workspace:meta-shortcut-always into master

activateLauncherMenu is invoked by the hard-coded "Meta" shortcut in KWin. The activation key is not configurable and therefore does not make sense to have different behaviors depending on whether a shortcut is configured for the application menu or not.

Or to say it in a easy way: I don't want to bind Meta+Shift+Alt+Space to the application menu so that Meta opens start menu. It makes no sense.

This patch fixes cases like [1].

In 267b6a8d introduced the activation helper alongside with this check, so it appears to be the intended behavior. But per the reasoning above, I consider this to be a review oversight.

[1] https://old.reddit.com/r/kde/comments/9rc6vh/super_key_stopped_working/

Merge request reports